# Version 9.1.118 (23 September 2024)

### Performance Management

#### Internal People List loading requires optimization (#120320)

**Problem**

- The loading of Internal People takes too long

**Solution**

- Optimise the query that brings back the list of people

#### The evaluation icon not showing on the agreement (#119959)

**Problem**

- The issue is that a review setup with its review periods is linked to more than 1 review year.  
    Eg Managers Review Setup with Mid-year and Final-Year is used on FY2023 and FY2024
- When the contract detail is retrieved and it determines whether or not to show the evaluations it checks whether the evaluation due date is captured for the period (Mid-Year) but does not filter based on the Year.
- This means it technically finds 2 Mid-year review items , with 1 having an evaluation date set and the other not.
- It picks the first one and then returns.
- This is why it may also appear to work 'randomly' because of the natural ordering of the query the one with the evaluation date sometimes gets picked first.

**Solution**

- The query now also takes into account the ReviewYear of the contract to ensure the correct review item dates are retrieved.

#### Add functionality to close the evaluation and show as wrong person on summary (#120155)

- When the toggle is selected, and submitted, mark the evaluation as completed 
    - Items to evaluate is then ex 0 / 6

<div id="bkmrk-%C2%A0-4"><div class="tau-lightbox-container">  
</div></div>[![image.png](https://signature.signifyhr.co.za/uploads/images/gallery/2024-09/scaled-1680-/OgtrqfeD4zRBXIHB-image.png)](https://signature.signifyhr.co.za/uploads/images/gallery/2024-09/OgtrqfeD4zRBXIHB-image.png)

<div id="bkmrk--1"><div class="tau-lightbox-container">  
</div></div><div id="bkmrk-%C2%A0-5"> </div><div id="bkmrk-on-the-evaluation-su">On the Evaluation summary, show in the comment the toggle wording:</div>[![image.png](https://signature.signifyhr.co.za/uploads/images/gallery/2024-09/scaled-1680-/WuPiwLoxvLlLp1oJ-image.png)](https://signature.signifyhr.co.za/uploads/images/gallery/2024-09/WuPiwLoxvLlLp1oJ-image.png)

<div id="bkmrk--3"><div class="tau-lightbox-container">  
</div></div><div id="bkmrk-%C2%A0-6"> </div>[![image.png](https://signature.signifyhr.co.za/uploads/images/gallery/2024-09/scaled-1680-/kxV5obyTuazKD6VT-image.png)](https://signature.signifyhr.co.za/uploads/images/gallery/2024-09/kxV5obyTuazKD6VT-image.png)

<div class="tau-lightbox-container" id="bkmrk--5">  
</div>#### The final score in the system is not the same as in the Performance Agreement Status report (#119225)

<div class="tau-lightbox-container" id="bkmrk-problem-2">**Problem**</div><div class="tau-lightbox-container" id="bkmrk-there-is-a-rounding-">- There is a rounding issue on the DWH and therefore the scores are not matched

</div><div class="tau-lightbox-container" id="bkmrk--6"></div><div class="tau-lightbox-container" id="bkmrk-solution-2">**Solution**</div><div class="tau-lightbox-container" id="bkmrk-create-custom-roundi">- Create custom rounding function to force round half up rounding and replace toFixed usages

</div><div class="tau-lightbox-container" id="bkmrk--7"></div><div class="tau-lightbox-container" id="bkmrk--8"></div>####  

#### The manager’s general comments are not visible in the employee's contract (#119923)

<div class="tau-lightbox-container" id="bkmrk-problem-3">**Problem**</div><div class="tau-lightbox-container" id="bkmrk-the-general-comments">- The general comments only showed when the agreement was submitted

</div><div class="tau-lightbox-container" id="bkmrk--9"></div><div class="tau-lightbox-container" id="bkmrk-solution-3">**Solution**</div><div class="tau-lightbox-container" id="bkmrk-always-show-general-">- Always show General Comments to both parties

</div><div class="tau-lightbox-container" id="bkmrk--10"></div>---

### Ruleset Management

#### No load indicator is displayed on the screen when clicking on the Ruleset or Cancel button (#102903)

<div class="tau-lightbox-container" id="bkmrk-problem-4">**Problem**</div><div class="tau-lightbox-container" id="bkmrk-there-is-no-loading-">- There is no loading indicator when clicking on a Ruleset

</div><div class="tau-lightbox-container" id="bkmrk--12"></div><div class="tau-lightbox-container" id="bkmrk-solution-4">**Solution**</div><div class="tau-lightbox-container" id="bkmrk-implemented-the-load">- Implemented the loading indicator

</div><div class="tau-lightbox-container" id="bkmrk--13"></div>---

### Languages

#### Add default culture en-GB (#114371)

<div class="tau-lightbox-container" id="bkmrk-problem-5">**Problem**</div><div class="tau-lightbox-container" id="bkmrk-currently%2C-the-date-">- Currently, the date displayed in the V8 system is American and this causes the date picker not to work

</div><div class="tau-lightbox-container" id="bkmrk--15"></div><div class="tau-lightbox-container" id="bkmrk-solution-5">**Solution**</div><div class="tau-lightbox-container" id="bkmrk-replace-en-us%2Fen-uk-">- Replace en-US/en-UK with en-GB as the default language

</div><div class="tau-lightbox-container" id="bkmrk--16"></div>---

### People Management

#### Fix the styling of the Manage Person button (#113511)

<div class="tau-lightbox-container" id="bkmrk-problem-6">**Problem**</div><div class="tau-lightbox-container" id="bkmrk-styling-is-not-stand">- Styling is not standard

</div><div class="tau-lightbox-container" id="bkmrk--18"></div><div class="tau-lightbox-container" id="bkmrk-solution-6">**Solution**</div><div class="tau-lightbox-container" id="bkmrk-make-the-button-a-st">- Make the button a standard button

</div>---

### Identity

#### SSO issues (#120492)

<div class="tau-lightbox-container" id="bkmrk--20"></div><div class="tau-lightbox-container" id="bkmrk-problem-7">**Problem**</div><div class="tau-lightbox-container" id="bkmrk-the-sso-integration-">- The SSO integration between V8 and V9 not working

</div><div class="tau-lightbox-container" id="bkmrk--21"></div><div class="tau-lightbox-container" id="bkmrk-solution-7">**Solution**</div><div class="tau-lightbox-container" id="bkmrk-with-the-update-to-.">With the update to .NET 8, the user identity ID is now retrieved from the 'nameidentifier' claim instead of the 'sub' claim.</div><div class="tau-lightbox-container" id="bkmrk--22"></div><div class="tau-lightbox-container" id="bkmrk--23"></div>